Image Delivery Sizes

TruThemes

TruThemes

Member
Can I rerun thumbnails and image optimizations and re-sync them up to R2?
Where can I find your Docs?
Does srcset still work properly from R2?
 
Sort by date Sort by votes
digitalpoint said:
Hmmmm… do you have anything else that might be mucking with images? Like a different plugin?

Also, did you upload the new Pro version? Needs that too.
Click to expand...
Where do I download it from? I can't find it in my account.
Seems like I installed the free one from wordpress.org and added the license I purchased. No?
Regards,
~ Cory C.
 
Upvote 0 Downvote
I disabled the image converter plugin. I only have the Pro plugin installed. When I open the "Add Plugin"
dialog and search for yours, it says it's installed allready.

I deleted it and installed it from WP; it says it's the pro version after activating it.
 
Upvote 0 Downvote
Hmmm... just to be 100% certain, I went back and tested it again, and it's definitely working when I try it. I uploaded a .jpg image to the WordPress Media area and the info for it ends up as a webp:

Uploaded on: August 6, 2024
Uploaded by: Shawn
Stored in R2: Yes
R2 bucket: Site bucket
File name: SatyrsArriving.webp
File type: image/webp
File size: 27 KB
Dimensions: 768 by 1024 pixels

I just downloaded the pro plugin from this site to make sure it didn't somehow end up with some incorrect files, and they are okay. If you look in the wp-content/plugins/app-for-cf-pro/DigitalPoint/Cloudflare/BasePubAdvanced.php file, make sure it has this line in it:

PHP: 
add_filter('wp_handle_upload_prefilter', [$this, 'filterWpUploadPrefilter']);

That should only be there in the 1.8.6 version and if it's missing, it's an old version somehow.

Beyond that, some other things to check:
  • Make sure R2 is enabled in admin area (if the uploaded file ends up in your R2 bucket, it's safe to say it's enabled)
  • Make sure the WEBP compression level is > 0 (internally 0 means it's disabled)
Beyond that it's fairly straight foroward... it makes sure the expected uploaded file exists, if it does, it checks the image format for the file to make sure it's a PNG or JPG... and if it is, it does the conversion.

Any chance you could .zip up an image file it's not working with and send me the link to the .zip? Might be worthwhile to look at the raw image file to see if internally PHP is thinking it's not a PNG or JPG somehow.
 
Upvote 0 Downvote
find: ‘BasePubAdvanced.php’: No such file or directory

I deleted both free and Pro plugins and reinstalled the Pro version. I don't even see it in the admin menu anymore.
 
Upvote 0 Downvote
Want to zip up one of the images that isn’t converting to WebP and give me a link to it? Should check to see if PHP is understanding if it’s the right source format.
 
Upvote 0 Downvote
The good news is that it's not the image (just dragged your image to the Media section and it converted it as expected).

With compression set to 80%:

Uploaded on: August 7, 2024
Uploaded by: Shawn
Stored in R2: Yes
R2 bucket: Site bucket
File name: herbs-for-life-yin-yang-leaves_300px.webp
File type: image/webp
File size: 12 KB
Dimensions: 300 by 300 pixels

With compression set to 70%:

Uploaded on: August 7, 2024
Uploaded by: Shawn
Stored in R2: Yes
R2 bucket: Site bucket
File name: herbs-for-life-yin-yang-leaves_300px.webp
File type: image/webp
File size: 11 KB
Dimensions: 300 by 300 pixels

So at least the source image can be ruled out as the issue.

I built a little PHP file you can upload to your site and run (access via browser) that will return some info about your server:

PHP: 
<?php

    echo
        'PHP version: ' . PHP_VERSION . "\r\n<br />" .
        'PHP OS: ' . PHP_OS . "\r\n<br />" .
        'Imagick class exists: ' . class_exists('Imagick') . "\r\n<br />" .
        'Imagick supports WebP: ' . (\Imagick::queryformats('WEBP') ? 1 : 0) . "\r\n<br />" .
        'GD w/ WebP support: ' . function_exists('imagewebp') . "\r\n<br />" .
        'exif_imagetype() function exists: ' . function_exists('exif_imagetype') . "\r\n<br />" .
        'image.png format: ' . exif_imagetype('image.png') . "\r\n<br />";

Upload that to the root of your website as a file named test.php and also upload any PNG image to the same place with the file name image.png. Then access it in your browser by going to http://yourdomain.com/test.php, and then copy/paste the results here.

If everything looks good there, the only other culprit I can think of would be if WordPress is somehow giving us an unexpected file location (it's supposed to report where the original [temporary] file uploaded is in the local filesystem), so will build something to test that next if needed.
 
Upvote 0 Downvote
Results:

PHP version: 8.2.15
PHP OS: Linux
Imagick class exists: 1
Imagick supports WebP: 1
GD w/ WebP support: 1
exif_imagetype() function exists: 1
image.png format: 3
Click to expand...

Since I've removed and reinstalled it, I will upload some other images and see what happens. I don't know why I didn't already.
 
Upvote 0 Downvote
TruThemes said:
Results:

Since I've removed and reinstalled it, I will upload some other images and see what happens. I don't know why I didn't already.
Click to expand...
Okay... that looks as expected. If you edit your wp-content/plugins/app-for-cf-pro/src/DigitalPoint/Cloudflare/Base/PubAdvanced.php file and change this:
PHP: 
    public function filterWpUploadPrefilter($file)
    {
        $webpCompression = $this->option('cfWebpCompression');

        if (!$webpCompression || !file_exists($file['tmp_name']))
        {
            return $file;
        }
        $fileType = exif_imagetype($file['tmp_name']);

        if ($fileType != IMAGETYPE_JPEG && $fileType != IMAGETYPE_PNG)
        {
            return $file;
        }
...to this:
PHP: 
    public function filterWpUploadPrefilter($file)
    {
        $webpCompression = $this->option('cfWebpCompression');

        header('Debug: file|' . json_encode($file), false);
        header('Debug: webPCompression|' . $webpCompression, false);

        if (!$webpCompression || !file_exists($file['tmp_name']))
        {
            header('Debug: noFile', false);
            return $file;
        }
        $fileType = exif_imagetype($file['tmp_name']);

        if ($fileType != IMAGETYPE_JPEG && $fileType != IMAGETYPE_PNG)
        {
            header('Debug: wrongType|' . $fileType, false);
            return $file;
        }

That will output extra "Debug" headers in the underlying HTTP request which will (hopefully) give the exact reason it thinks it can't do the format change. If you go to your WordPress Media library, right click the page to "inspect" it, then go to the Network tab. Drag a PNG or JPG image into the media library and then look on that Network tab. You should see a request for async-upload.php get called. On that line, look at the Headers tab and the Response Headers should have multiple Debug headers. For example when it worked as expected when I tried, I ended up with 2 Debug headers like so:

Debug: file|{"name":"SatyrsArriving.jpeg","type":"image\/jpeg","tmp_name":"\/tmp\/php4q8l9c","error":0,"size":104258}
Debug: webPCompression|70
Click to expand...

Possibly additional ones if it encountered an error preventing the conversion.

What do you get as far as Debug headers when you do it?

Sorry about the hassle of adding debugging code. Not able to debug it on my end since I can't get it to *not* work, so trying to figure out what's unique about your server setup.
 
Upvote 0 Downvote
It's working.
My theory then is this; that I added the license to the free plugin, and even though I installed the updated plugin over the top of it, something remained that was interfering with the conversion.
 
Upvote 0 Downvote
You must log in or register to reply here.

Similar threads

TruThemes
  • Discussion
Still can't use srcset
Replies
9
Views
92
digitalpoint
digitalpoint
C
  • Discussion
Imagen error on Upload
Replies
2
Views
62
Carlos
C
C
  • Discussion
R2 Images in XenForo
Replies
3
Views
1K
digitalpoint
digitalpoint
V
  • Discussion
Turn off auto upload into cloudflare
Replies
1
Views
99
digitalpoint
digitalpoint
P
  • Question
Pre-Signed URLs
2
Replies
24
Views
294
digitalpoint
digitalpoint
Back
Top